home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 565830943

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3602#issuecomment-565830943 https://api.github.com/repos/pydata/xarray/issues/3602 565830943 MDEyOklzc3VlQ29tbWVudDU2NTgzMDk0Mw== 14808389 2019-12-15T17:51:05Z 2019-12-17T15:21:56Z MEMBER

I think once we decided what to do with the DataStore methods and how to treat the injected methods, we can merge?

Edit: I think we can just leave the accessor methods as is. This means we only have to decide what to do with dump_to_store and load_store. A grep over the code tells me that load_store is never used, tested or mentioned (from_store is mentioned but never defined or used): do we still support it? dump_to_store is mentioned and tested, so we definitely should put it somewhere (even if it is just api-hidden.rst).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  534329975
Powered by Datasette · Queries took 0.588ms · About: xarray-datasette