home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 565622102

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3498#issuecomment-565622102 https://api.github.com/repos/pydata/xarray/issues/3498 565622102 MDEyOklzc3VlQ29tbWVudDU2NTYyMjEwMg== 35968931 2019-12-13T21:53:08Z 2019-12-13T21:53:08Z MEMBER

I'm not sure we should merge changes if we're unsure how they will behave in certain circumstances.

On the other hand I am eager to keep the file number option because (1) attrs_file=-1 is the behaviour that I need

If we kept just the string specifier, you could still solve the problem of preserving the history: ```python files_to_open = ['filepath1', 'filepath2']

ds = open_mfdataset(files_to_open, attrs_file=files_to_open[-1]) `` But then the option would always have clear and well-defined behaviour, even in more complex cases likecombine_by_coordsorcombine='nested'` with a >1D input file list.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  520110180
Powered by Datasette · Queries took 0.67ms · About: xarray-datasette