home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 564335840

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3602#issuecomment-564335840 https://api.github.com/repos/pydata/xarray/issues/3602 564335840 MDEyOklzc3VlQ29tbWVudDU2NDMzNTg0MA== 14808389 2019-12-11T01:28:12Z 2019-12-11T01:28:12Z MEMBER

thanks for the review, @dcherian.

The Data*Coordinates objects are returned by the coords attributes of DataArray and Dataset. They are mostly treated as dict but they have a few public (i.e. not prefixed with an underscore) properties (e.g. dims), all of which don't have docstrings. I'll treat both classes as implementation detail.

Other than that, only the injection methods and the datastore methods remain for the manually written part. Unfortunately, the autodoc / autosummary warnings are due to a sphinx bug (see https://github.com/pydata/xarray/issues/3370#issuecomment-564124368), so our only option right now is to use nitpicky_ignore to silence them. I don't think we should, though. Instead, I'll try to silence all warnings that are not due to the bug and we can leave the rest to a potential round 4 or a sphinx / napoleon update.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  534329975
Powered by Datasette · Queries took 1.002ms · About: xarray-datasette