issue_comments: 560171094

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3529#issuecomment-560171094 https://api.github.com/repos/pydata/xarray/issues/3529 560171094 MDEyOklzc3VlQ29tbWVudDU2MDE3MTA5NA== 1217238 2019-12-01T23:02:03Z 2019-12-01T23:02:03Z MEMBER

Looking more carefully at this, I'm remembering now why I called this "deprecated." Eventually, we always want to keep track of indexes explicitly. Currently we don't do that, and in particular _replace_vars_and_dims does not do that.

My main reason for keeping it around was simply as a reminder that the functions that use it still need to be updated. It would be great to do that, but each usage should explicitly set indexes rather than setting indexes=None which we want to eventually stop doing.

Does that make sense?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   522562906