issue_comments: 556045623

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3550#issuecomment-556045623 https://api.github.com/repos/pydata/xarray/issues/3550 556045623 MDEyOklzc3VlQ29tbWVudDU1NjA0NTYyMw== 5635139 2019-11-20T15:10:41Z 2019-11-20T15:10:41Z MEMBER

Great start!

Thanks for the review @keewis

I think it's fine to leave Dataset for another PR; it'd be great to get this in, and given it's your first PR (welcome!) let's not bloat it

Test looks good. Let's make those adjustments you put in the TODO and add one for the other function? We could also add some variants which test along different dimensions / all NaNs / other special cases. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   525685973