home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 555915343

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2652#issuecomment-555915343 https://api.github.com/repos/pydata/xarray/issues/2652 555915343 MDEyOklzc3VlQ29tbWVudDU1NTkxNTM0Mw== 45787861 2019-11-20T09:20:39Z 2019-11-20T09:30:31Z NONE

Alright, I have done so and changed basestrings into str, now the tests run (mostly) through locally. bash 1 failed, 6539 passed, 1952 skipped, 37 xfailed, 31 warnings in 86.34s A general question concerning collaboration on existing PRs: Should I push the changes to my fork and then create a new PR that replaces @hrishikeshac's PR or shall I push to @hrishikeshac's fork and see whether it works to update the existing PR?

Or is there another option?

PS: Permission to push to hrishikeshac:corr is denied for me.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  396102183
Powered by Datasette · Queries took 0.522ms · About: xarray-datasette