issue_comments: 555299451

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3545#issuecomment-555299451 https://api.github.com/repos/pydata/xarray/issues/3545 555299451 MDEyOklzc3VlQ29tbWVudDU1NTI5OTQ1MQ== 1217238 2019-11-19T02:12:45Z 2019-11-19T02:12:45Z MEMBER

Thanks for working on this important issue!

There are a lot of edge cases that can come up in concat, so I think it would be very helpful to try to enumerate a broader set of unit tests for thoroughly testing this. For example: - Pre-existing vs non-pre-existing dimension - Pre-existing dimensions of different sizes - Missing data variables vs coordinates vs indexed coordinates

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   524043729