issue_comments: 555188018

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3519#issuecomment-555188018 https://api.github.com/repos/pydata/xarray/issues/3519 555188018 MDEyOklzc3VlQ29tbWVudDU1NTE4ODAxOA== 1217238 2019-11-18T20:09:48Z 2019-11-18T20:09:48Z MEMBER

Yes, looks good to me!

On Mon, Nov 18, 2019 at 12:01 PM Deepak Cherian notifications@github.com wrote:

@dcherian commented on this pull request.

In xarray/core/indexes.py https://github.com/pydata/xarray/pull/3519#discussion_r347582088:

@@ -100,3 +98,24 @@ def roll_index(index: pd.Index, count: int, axis: int = 0) -> pd.Index:

     return index[-count:].append(index[:-count])

 else:

     return index[:]

+

+

+def copy_indexes(

👍 The current version does this:

new_indexes = {k: v for k, v in indexes.items() if k not in exclude}

which should be fine?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3519?email_source=notifications&email_token=AAJJFVQ4WVPBST3ATQCHVFLQULYDJA5CNFSM4JM5MYX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL6VXTA#discussion_r347582088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVUEM3RJTPGTDSS5JYTQULYDJANCNFSM4JM5MYXQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   522308594