home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 554594809

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1739#issuecomment-554594809 https://api.github.com/repos/pydata/xarray/issues/1739 554594809 MDEyOklzc3VlQ29tbWVudDU1NDU5NDgwOQ== 1217238 2019-11-16T02:21:44Z 2019-11-16T02:21:44Z MEMBER

we would either have to raise an error or automatically transpose the second variable. Neither option sounds great to me.

Agree, I was thinking we'd transpose the second one, but fair if you think too invasive

Maybe this would be fine. We already do automatic alignment, and this is really not that much different.

It would be a breaking change, though, so we would need to roll it out slowly.

Perhaps this could be relaxed now that Python's dict always preserves the order in which items are added.

Ah OK. If we relaxed that, what would the order be? Just the order they were initially added, and so at least consistent through time (though not necessarily with the variables)?

Yes, that's right.

One potential concern is that this would expose a detail of xarray's data model that would not be easy for users to control. I can imagine that we might have internal xarray methods that inadvertently change dimension order.

So maybe this would make sense only if we also do your other suggested change (enforcing a consistent dimension order throughout a Dataset).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  276241764
Powered by Datasette · Queries took 0.683ms · About: xarray-datasette