home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 554500568

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3527#issuecomment-554500568 https://api.github.com/repos/pydata/xarray/issues/3527 554500568 MDEyOklzc3VlQ29tbWVudDU1NDUwMDU2OA== 1217238 2019-11-15T19:41:41Z 2019-11-15T19:41:41Z MEMBER

the difference is here, where in DataArrayGroupBy the original dimension order is restored. DatasetGroupBy does not do that, so the test requires the transpose

It was not entirely obvious to me how to generalize "restoring dimension order" to Dataset. On a Dataset, it is not entirely clear which variable dimension order should be copied from. Maybe each variable in the result should have dimension order copied from the variable with the same name in the original dataset? But then what about new variables?

I agree @max-sixty, let's not worry about this too much for now.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  522523336
Powered by Datasette · Queries took 0.565ms · About: xarray-datasette