issue_comments: 554497403

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3526#issuecomment-554497403 https://api.github.com/repos/pydata/xarray/issues/3526 554497403 MDEyOklzc3VlQ29tbWVudDU1NDQ5NzQwMw== 3780274 2019-11-15T19:32:33Z 2019-11-15T19:32:33Z NONE

mmm, I am not sure I understand. Currently

ds = xr.Dataset() ds.attrs['foo'] = {'bar': 1} ds.to_zarr('foo.zarr', mode='w')

does not work. This is because dict is not allowed in the list of types that the attributes are validated against. My feeling is this should not produce an error.

This PR just addresses that so the code above works. The following works as well:

ds = xr.open_zarr('foo.zarr') ds.attrs['foo'] {'bar': 1}

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   522519084