issue_comments: 553958685

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3532#issuecomment-553958685 https://api.github.com/repos/pydata/xarray/issues/3532 553958685 MDEyOklzc3VlQ29tbWVudDU1Mzk1ODY4NQ== 10194086 2019-11-14T16:11:28Z 2019-11-14T16:12:47Z MEMBER

I think the current code will mutate the existing index name, is that correct?

Currently the index is recreated with the same name (even if it does not change it's name). We could change the following lines

https://github.com/pydata/xarray/blob/40588dc38ddc2d573e3dc8c63b2e6533eb978656/xarray/core/dataset.py#L2649-L2651

python new_name = name_dict.get(k, None) if new_name is None or new_name not in dims_set: continue to skip doing this (not sure if there is an edge cas I am missing here).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   522884917