home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 553222315

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3516#issuecomment-553222315 https://api.github.com/repos/pydata/xarray/issues/3516 553222315 MDEyOklzc3VlQ29tbWVudDU1MzIyMjMxNQ== 5635139 2019-11-13T03:28:14Z 2019-11-13T03:28:14Z MEMBER

Awesome, thanks @keewis !!

I think the changes in https://github.com/pydata/xarray/commit/5d9d263e40e1f67910cbefaf96d46a91c560b8b5 are good (and having one standard is good for long-term readability)

For old whatsnew entries, I think it's fine that the references have decayed if we can silence the warnings (maybe easiest way is your suggestion to just remove the links, though)

Should we put an issue in for the numpy docstrings?

As a follow-up, is there a way to add a check in CI so these don't stack up again as people make changes? Or maybe difficult without stamping them all out?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  521887948
Powered by Datasette · Queries took 1.225ms · About: xarray-datasette