issue_comments: 552493241

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3502#issuecomment-552493241 https://api.github.com/repos/pydata/xarray/issues/3502 552493241 MDEyOklzc3VlQ29tbWVudDU1MjQ5MzI0MQ== 2448579 2019-11-11T15:34:55Z 2019-11-11T15:34:55Z MEMBER

Thanks for taking this on, Anderson.

You'll have to convert back from the numpy array before exiting that function. It may be simpler if you avoid the cast and just keep the change from equivalent to allclose_or_equiv.

For reference, here's how xarray determines dtype for netCDF4 https://github.com/pydata/xarray/blob/4e9240a2087ffbf119919e1ac98046bbf164f94d/xarray/backends/netCDF4_.py#L131-L141

(I found this by working looking for the createVariable statement here) https://github.com/pydata/xarray/blob/4e9240a2087ffbf119919e1ac98046bbf164f94d/xarray/backends/netCDF4_.py#L439-L485

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   520306672