issue_comments: 551142493
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/3409#issuecomment-551142493 | https://api.github.com/repos/pydata/xarray/issues/3409 | 551142493 | MDEyOklzc3VlQ29tbWVudDU1MTE0MjQ5Mw== | 6213168 | 2019-11-07T15:59:01Z | 2019-11-07T15:59:01Z | MEMBER | @dcherian I didn't try running the PR code, but I don't think so? The PR may mean (must test) that nanmin() and nanmax() now work with NaT. However, as highlighted above https://github.com/pydata/xarray/issues/3409#issuecomment-544299242 xarray is invoking min() on an array that contains NaT - which in numpy 1.17 ignores them, while in 1.18 correctly returns NaT. Does anybody have the time to test it? |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
508167922 |