home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 548096875

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3447#issuecomment-548096875 https://api.github.com/repos/pydata/xarray/issues/3447 548096875 MDEyOklzc3VlQ29tbWVudDU0ODA5Njg3NQ== 14808389 2019-10-30T20:25:11Z 2019-10-30T20:25:11Z MEMBER

I think this is ready for review and merge. I am especially interested in comments on Dataset.__init__ and Dataset.test_merge, since at the moment they seem to test the same code.

There is still a lot to do, and I will also have to go over all tests (DataArray and Dataset) to remove any obvious mistakes (I found a lot from the code in #3238), but if there are any that are not so obvious, they probably won't be found until someone works on making the tests pass.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  512564022
Powered by Datasette · Queries took 0.48ms · About: xarray-datasette