issue_comments: 545512847

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2922#issuecomment-545512847 https://api.github.com/repos/pydata/xarray/issues/2922 545512847 MDEyOklzc3VlQ29tbWVudDU0NTUxMjg0Nw== 10194086 2019-10-23T15:55:35Z 2019-10-23T15:55:35Z MEMBER

I decided to replace all NaN in the weights with 0. Can we raise an error instead? It should be easy for the user to do weights.fillna(0) instead of relying on xarray's magical behaviour.

I agree, requiring valid weights is a sensible choice.

if weights sum to 0 it returns NaN (and not inf) Should we raise an error here?

Im not sure... Assume I want to do a meridional mean and only have data over land, this would then raise an error, which is not what I want. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   437765416