issue_comments: 544770938

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3425#issuecomment-544770938 https://api.github.com/repos/pydata/xarray/issues/3425 544770938 MDEyOklzc3VlQ29tbWVudDU0NDc3MDkzOA== 1217238 2019-10-22T01:15:19Z 2019-10-22T01:15:19Z MEMBER

This looks fantastic! Really great to have you working on this!

Some specific feedback:

  1. Yes, I agree it would be nice to align the Attributes text, maybe this could make use of an HTML table?
  2. Maybe bold would look better than underline for coordinates that are dimensions? I find the underline makes text a little hard to read. Happy to leave this up to you, though.
  3. On my Ubuntu desktop, the "+" icon is bright yellow, which I'm guessing is not what was intended. Maybe it would better to stick with the three circle "data" icon?
  4. What happens if there is a really long variable name? I had a version of the jsfiddle that expanded names when you hovered over them.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   510294810