issue_comments: 543358453

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2922#issuecomment-543358453 https://api.github.com/repos/pydata/xarray/issues/2922 543358453 MDEyOklzc3VlQ29tbWVudDU0MzM1ODQ1Mw== 10194086 2019-10-17T20:56:32Z 2019-10-17T20:59:08Z MEMBER

I finally made some time to work on this - altough I feel far from finished...

  • added a DatasetWeighted class
  • for this I pulled the functionality our of DataArrayWeighted class in to own functions taking da and weights as input
  • the tests need more work
  • implanted the functionality using xr.dot -> this makes the logic a bit more complicated
  • I think the failure in Linux py37-upstream-dev is unrelated

Questions: * does this implementation look reasonable to you? * xr.dot does not have a axis keyword is it fine if I leave it out in my functions? * flake8 fails because I use @overload for typing -> should I remove this? * Currently I have the functionality 3-times: once as _weighted_sum, once as da.weighted.sum() and once as ds.weighted().sum: how do I best test this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   437765416