issue_comments: 542181588

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3238#issuecomment-542181588 https://api.github.com/repos/pydata/xarray/issues/3238 542181588 MDEyOklzc3VlQ29tbWVudDU0MjE4MTU4OA== 14808389 2019-10-15T12:13:40Z 2019-10-15T18:53:03Z MEMBER

I updated the PR so that all the DataArray methods I found in the docs have a test, the only exception is to_unstacked_dataset where I don't know what the result should look like: Consider ```python

data = [[0, 10, 20], [30, 40, 50]] x = [0, 1] y = [0, 1, 2] arr = xr.DataArray(data=data, coords={"x": x, "y": y}, dims=("x", "y")) arr.stack(z=("x", "y")).to_unstacked_dataset(dim="z") <xarray.Dataset> Dimensions: (y: 3) Coordinates: * y (y) int64 0 1 2 Data variables: 0 (y) int64 0 10 20 1 (y) int64 30 40 50 `` and supposing that indexes keep the units, what should the result of the above, but with units onx`, look like?

Edit: I assumed this to be the same as datetime, which means object labels instead of strings. So now only the top-level functions and dataset are missing.

I'd like to leave these two and replacing assert_equal_with_units with either xarray.testing.assert_identical or xarray.testing.assert_allclose or a combination of both to new PRs, so now this should be ready for review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   484015016