issue_comments: 539551326

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3381#issuecomment-539551326 https://api.github.com/repos/pydata/xarray/issues/3381 539551326 MDEyOklzc3VlQ29tbWVudDUzOTU1MTMyNg== 2448579 2019-10-08T14:52:08Z 2019-10-08T14:52:08Z MEMBER

Thanks @khaeru.

  1. This looks like a sparse error: https://sparse.pydata.org/en/latest/generated/sparse.concatenate.html: ValueError – If all elements of arrays don’t have the same fill-value.

  2. This too is a sparse error: Cannot provide a fill-value in combination with something that already has a fill-value So you'll need to figure out how to change fill values on sparse arrays.

  3. This needs some investigation if you're up for it. ``` # But simple operations again create objects with potentially incompatible

fill-values

d = c.sum(dim='bar') print(d.data.fill_value) # 0.0 ```

I also see that we aren't testing for fill_value changes in test_sparse.py so it would be good to add some of those even if they fail currently so that someone else (like you!) can come in and fix it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   503711327