issue_comments: 538577126

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3268#issuecomment-538577126 https://api.github.com/repos/pydata/xarray/issues/3268 538577126 MDEyOklzc3VlQ29tbWVudDUzODU3NzEyNg== 6213168 2019-10-04T22:14:38Z 2019-10-04T22:16:03Z MEMBER

@gmaze Dataset.drop does not mutate the state of the original object, so it's conceptually wrong for your clean() method to mutate the accessor state too. It should be: python def clean(self): return self.obj.drop(self.added) The new dataset returned will have no accessor cache, and will recreate an instance on the fly on first access.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   485708282