issue_comments: 537527958

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1533#issuecomment-537527958 https://api.github.com/repos/pydata/xarray/issues/1533 537527958 MDEyOklzc3VlQ29tbWVudDUzNzUyNzk1OA== 1217238 2019-10-02T14:46:40Z 2019-10-02T14:46:40Z MEMBER

We should probably merge my merging refactor before doing much more on this...

On Wed, Oct 2, 2019 at 7:28 AM Deepak Cherian notifications@github.com wrote:

Nice example!

I tracked this down to

  1. as_variable being called when extracting the index. This seems sensible.

https://github.com/pydata/xarray/blob/21705e61503fb49f000186c0d556e5623bd5ac82/xarray/core/merge.py#L413-L420 2. as_variable being called again in the expand_variable_dicts call in merge_core (should be avoided):

https://github.com/pydata/xarray/blob/21705e61503fb49f000186c0d556e5623bd5ac82/xarray/core/merge.py#L493-L497

We need to replace the appropriate objects in aligned with IndexVariables from indexes if indexes is not None.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/1533?email_source=notifications&email_token=AAJJFVQSTUPMQV6FAQGHX5LQMSVXFA5CNFSM4DYTHFMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAE6GKI#issuecomment-537518889, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVW6FY37NVRUPXSMQU3QMSVXFANCNFSM4DYTHFMA . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   253395960