issue_comments: 536690748
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/3349#issuecomment-536690748 | https://api.github.com/repos/pydata/xarray/issues/3349 | 536690748 | MDEyOklzc3VlQ29tbWVudDUzNjY5MDc0OA== | 1217238 | 2019-09-30T18:29:10Z | 2019-09-30T18:29:10Z | MEMBER | From a user perspective, I think people prefer to find stuff in one place. From a maintainer perspective, as long as it's somewhat domain agnostic (e.g., "physical sciences" rather than "oceanography") and written to a reasonable level of code quality, I think it's fine to toss it into xarray. "Already exists in NumPy/SciPy" is probably a reasonable proxy for the former. So I say: yes, let's toss in polyfit, along with fast fourier transforms. If we're concerned about clutter, we can put stuff in a dedicated namespace, e.g., |
{
"total_count": 3,
"+1": 3,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
499477363 |