home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 536118536

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3348#issuecomment-536118536 https://api.github.com/repos/pydata/xarray/issues/3348 536118536 MDEyOklzc3VlQ29tbWVudDUzNjExODUzNg== 1217238 2019-09-27T22:43:48Z 2019-09-27T22:43:48Z MEMBER

It's also not clear to me how this managed to change/break but I think we should consider it a bug.

I agree that the right fix is to write an explicit astype method, but I don't think there's a good reason for keep_attrs=False in this case. astype isn't really changing the data, just changing how the data is represented so I think it makes sense to always preserve attributes.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  499196320
Powered by Datasette · Queries took 237.714ms · About: xarray-datasette