issue_comments: 535979151

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3348#issuecomment-535979151 https://api.github.com/repos/pydata/xarray/issues/3348 535979151 MDEyOklzc3VlQ29tbWVudDUzNTk3OTE1MQ== 2448579 2019-09-27T15:06:47Z 2019-09-27T15:06:47Z MEMBER

Should we switch keep_attrs to True by default or be determined by the global keep_attrs setting? (also I don't know why this worked in 0.12.1)

https://github.com/pydata/xarray/blob/6ece6a1cf424c3080e216fad8fc8058d3b70aadc/xarray/core/dataset.py#L4388-L4401

The more general solution for DataArrays is to finish up #2070 (see also #2049). @robbibt are you you up for doing this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   499196320