home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 535056774

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3312#issuecomment-535056774 https://api.github.com/repos/pydata/xarray/issues/3312 535056774 MDEyOklzc3VlQ29tbWVudDUzNTA1Njc3NA== 2448579 2019-09-25T14:42:58Z 2019-09-25T14:42:58Z MEMBER
  1. Promote all inputs to Datasets (or @friedrichknuth's "dict_like_objects")
  2. Do the combining

I agree.

  1. If the result has only a single variable then demote from Dataset to DataArray?

I think the simplest solution is to always return Dataset? Then behaviour is always predictable. Otherwise you could combine a bunch of Datasets with a single variable and end up with a DataArray. Alternatively, return a DataArray only when all inputs are DataArrays with the same name.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  494210818
Powered by Datasette · Queries took 0.567ms · About: xarray-datasette