issue_comments: 534755294

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3199#issuecomment-534755294 https://api.github.com/repos/pydata/xarray/issues/3199 534755294 MDEyOklzc3VlQ29tbWVudDUzNDc1NTI5NA== 1217238 2019-09-24T21:26:04Z 2019-09-24T21:26:04Z MEMBER

Yikes, OK. Yes, it would be good to open an issue on the RTD GitHub page to discuss our options. --upgrade-strategy eager seems like a bad idea for us -- it really undermines the value of dependency pinning.

On Tue, Sep 24, 2019 at 1:31 PM keewis notifications@github.com wrote:

it seems all of these problems boil down to that single command. What gets executed is (essentially)

$ python -m pip install --upgrade --upgrade-strategy eager .

which upgrades pandas to 0.25.1, but leaves dask as is because it is an optional dependency. This, however, defeats the purpose of version pinning in the conda file (or a requirements file).

I can't find an option to tell readthedocs to install without the eager upgrade (normal upgrade is fine). Maybe ask support? The addition of the upgrade strategy happened in readthedocs/readthedocs.org#5635 https://github.com/readthedocs/readthedocs.org/pull/5635

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3199?email_source=notifications&email_token=AAJJFVULDVAUPID5WWAZAF3QLJ2JXA5CNFSM4IKVN6A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7PWUAY#issuecomment-534735363, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVRI6S3TML3E27VEYNTQLJ2JXANCNFSM4IKVN6AQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   479063574