issue_comments: 534593621

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3337#issuecomment-534593621 https://api.github.com/repos/pydata/xarray/issues/3337 534593621 MDEyOklzc3VlQ29tbWVudDUzNDU5MzYyMQ== 2448579 2019-09-24T14:47:17Z 2019-09-24T14:47:17Z MEMBER

@nbren12 I had a quick look at this on my commute this morning.

  1. Somehow squeeze=True when it is False in the groupby constructor. Not sure why.

  2. For squeeze=True, the Dataset behaviour is correct since you're attempting to reduce along the grouped dimension which has been squeezed out. DataArray is incorrectly reducing all dimensions in each group (This was deprecated in 0.13)

I have partial fix in #3338 with a better error message but it needs tests and docs; and also a fix for squeeze being True by default. If you have time, can you finish that up?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   497427114