issue_comments: 533228830
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/3322#issuecomment-533228830 | https://api.github.com/repos/pydata/xarray/issues/3322 | 533228830 | MDEyOklzc3VlQ29tbWVudDUzMzIyODgzMA== | 6213168 | 2019-09-19T17:23:10Z | 2019-09-19T17:23:10Z | MEMBER | Hi @weipeng1999 , could you link the reference implementation in numpy/scipy? I think this would be niche-ish. I would personally try to keep xarray free of functionality that only a tiny fraction of the users actually use - particularly when such functionality can be implemented with a trivial wrapper by the users themselves. e.g. at the moment we have exactly one scipy function being wrapped, and that's linear interpolation which is useful to a lot of people. I think this falls into a more general discussion on how niche a function must be in order to be excluded from the library - @shoyer what's your opinion? Regardless, I would like to point you to https://xarray-extras.readthedocs.io which is a module that I created exactly for this kind of cases (PRs are welcome). |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
495799492 |