issue_comments: 533145925

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3238#issuecomment-533145925 https://api.github.com/repos/pydata/xarray/issues/3238 533145925 MDEyOklzc3VlQ29tbWVudDUzMzE0NTkyNQ== 14808389 2019-09-19T14:04:12Z 2019-09-19T14:04:12Z MEMBER

I'm currently working on the tests for the comparison methods (DataArray.equals, DataArray.identical and DataArray.broadcast_equals) and I'm trying to figure out what equals and identical return. equals is easy: just make sure the wrapped quantities are equal. identical is a stricter version of equals, so I was wondering whether it should also return False if the values are equal, but in compatible units (like 10 cm and 0.1 m)? Any thoughts on this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   484015016