issue_comments: 532968459
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/3312#issuecomment-532968459 | https://api.github.com/repos/pydata/xarray/issues/3312 | 532968459 | MDEyOklzc3VlQ29tbWVudDUzMjk2ODQ1OQ== | 1217238 | 2019-09-19T05:11:06Z | 2019-09-19T05:11:06Z | MEMBER | Thinking about the interface here, would it make sense for the combine methods to always return an object of the same type as the inputs? E.g., list of DataArray -> DataArray, list of Dataset -> Dataset? Effectively, we would disable the automatic merging when working with DataArray objects and only do concat (ignoring DataArray names). I guess the confusing part is that in concat we always return the same type as the inputs, vs merge where we always return a Dataset. And of course, combine can do both! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
494210818 |