issue_comments: 532794909

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3315#issuecomment-532794909 https://api.github.com/repos/pydata/xarray/issues/3315 532794909 MDEyOklzc3VlQ29tbWVudDUzMjc5NDkwOQ== 35968931 2019-09-18T17:53:43Z 2019-09-18T17:53:43Z MEMBER

Hmm I can look at this properly at the weekend but in the meantime the logic was motivated by discussion in #2777. If the test doesn't make sense in that context then it's not right.

On Wed, 18 Sep 2019, 18:16 Deepak Cherian, notifications@github.com wrote:

Yes/

https://github.com/pydata/xarray/blob/fddced063b7ecbea6254dc1008bb4db15a5d9304/xarray/tests/test_combine.py#L467-L478

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/3315?email_source=notifications&email_token=AISNPI6OZK7YES6JUSDSWCLQKJO7VA5CNFSM4IXWOSZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7AZOBI#issuecomment-532780805, or mute the thread https://github.com/notifications/unsubscribe-auth/AISNPI3UMSS4MAOZKQLNRKTQKJO7VANCNFSM4IXWOSZQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   494906646