issue_comments: 525832695

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3271#issuecomment-525832695 https://api.github.com/repos/pydata/xarray/issues/3271 525832695 MDEyOklzc3VlQ29tbWVudDUyNTgzMjY5NQ== 23618263 2019-08-28T16:59:10Z 2019-08-28T16:59:10Z CONTRIBUTOR

I think this could be achieved by checking len(dims) == len(shape) in the case where dims was explicitly provided, i.e., around this line:

Thanks for the suggestion. The raise now happens if len(dims) != len(shape) near the line you suggested.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   486153978