home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 525325332

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3227#issuecomment-525325332 https://api.github.com/repos/pydata/xarray/issues/3227 525325332 MDEyOklzc3VlQ29tbWVudDUyNTMyNTMzMg== 868027 2019-08-27T14:24:35Z 2019-08-27T14:24:35Z CONTRIBUTOR

Hi @gwgundersen some clarification on those "extra snippets", github is not aware of the ipython directive so it prints those out like code snippets. In the actual built docs, these don't appear (the :suppress: in that block does this).

I personally feel that the code that makes these temporary files should be responsible for cleaning it up, especially since it already tries, and they aren't build artifacts needed in other steps. I'd probably reach for the tempfile.TemporaryDirectory in the standard library and bracket the dask docs in a create, cd in, cd out, cleanup type flow. There is already a suppressed setup ipython block at the top of the dask docs too.

@max-sixty Any opinions on which option we should go for?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  482023929
Powered by Datasette · Queries took 5.726ms · About: xarray-datasette