home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 525252528

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3268#issuecomment-525252528 https://api.github.com/repos/pydata/xarray/issues/3268 525252528 MDEyOklzc3VlQ29tbWVudDUyNTI1MjUyOA== 10050469 2019-08-27T11:03:47Z 2019-08-27T11:04:10Z MEMBER

Interesting, thanks!

As an accessor maintainer, I can ensure that at least one accessor implementation is storing state ;-). But this state is based on the xarray object itself: for example, we derive georeferencing information and store the names of the coordinate variabless we know are going to be useful to us later. That is, every new call to __init__ based on a modified object will trigger a new parsing, and we don't come into the situation you describe above.

Getting rid of the caching logic would mean some performance loss to us, yes, but I don't know if it's "worse" than the circular reference issue you describe or not.

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  485708282
Powered by Datasette · Queries took 0.863ms · About: xarray-datasette