home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 524881974

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2956#issuecomment-524881974 https://api.github.com/repos/pydata/xarray/issues/2956 524881974 MDEyOklzc3VlQ29tbWVudDUyNDg4MTk3NA== 14808389 2019-08-26T14:26:34Z 2019-08-26T14:26:34Z MEMBER

We could add the experimental option for allowing subclasses for testing purposes, but ultimately I think we want to insist that objects we use inside data implement __array_function__, regardless of whether they are a numpy array subclass or duck array. Otherwise there's no way complicated operations like concat are going to work properly.

@shoyer: What kind of testing would that be? If this is something that would be removed again in the future and has no actual value, feel free to close (but don't forget the original PR). Otherwise, I'd be happy to continue working on this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  443157666
Powered by Datasette · Queries took 0.787ms · About: xarray-datasette