issue_comments: 523183790

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2956#issuecomment-523183790 https://api.github.com/repos/pydata/xarray/issues/2956 523183790 MDEyOklzc3VlQ29tbWVudDUyMzE4Mzc5MA== 14808389 2019-08-20T20:35:02Z 2019-08-20T20:35:02Z MEMBER

I'm not too sure about putting _asarray into npcompat.py, but apart from that I would say it is ready to be merged.

However, the question of whether or not this PR is obsolete now still remains: if one were to replace quantities with pint, the test checking that this does not work without the proposed changes enabled is the only one that fails.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   443157666