home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 519750994

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3194#issuecomment-519750994 https://api.github.com/repos/pydata/xarray/issues/3194 519750994 MDEyOklzc3VlQ29tbWVudDUxOTc1MDk5NA== 5635139 2019-08-09T02:12:32Z 2019-08-09T02:23:11Z MEMBER

I think pre-commit is great, but that it's too much burden to compel new contributors to use by adding its effects to CI checks. I think we've been fairly successful recently at having some less technical folks contribute; keen not to erect even small barriers.

We could add this to pre-commit but not to CI; there'd be some unrelated changes in PRs though.

If anyone is up for a side project - a tool that submits PRs whenever someone commits non-idiomatic code!

Open minded as ever though

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  478690528
Powered by Datasette · Queries took 0.707ms · About: xarray-datasette