home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 518045169

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3153#issuecomment-518045169 https://api.github.com/repos/pydata/xarray/issues/3153 518045169 MDEyOklzc3VlQ29tbWVudDUxODA0NTE2OQ== 1217238 2019-08-04T23:33:45Z 2019-08-04T23:33:45Z MEMBER

A fix in pandas that I can imagine is to modify the pd.Index to retain the dtype similar to the PandasIndexAdapter in xarray/core/indexing. However, it seems to me that their design it to coerce any float to float64, so I did not feel they would consider this to be a bug. I would try to dig into such solution more if you recommend so.

Yes, after thinking a little bit more about this I think you're totally right.

Pandas only has Float64Index. When xarray makes an index for float32 data, we use a Float64Index under the hood for look-ups, but the fact that index represents float32 data is only known to xarray, not pandas.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  470712573
Powered by Datasette · Queries took 0.852ms · About: xarray-datasette