home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 517400198

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3117#issuecomment-517400198 https://api.github.com/repos/pydata/xarray/issues/3117 517400198 MDEyOklzc3VlQ29tbWVudDUxNzQwMDE5OA== 1217238 2019-08-01T18:14:38Z 2019-08-01T18:14:38Z MEMBER

2. Operations not supported by the duck type. This happens in a few cases with pydata/sparse, and would have to be solved upstream, unless it's a special case where it might be okay to coerce. e.g. what happens with binary operations that mix array types?

This is totally fine for now, as long as there are clear errors when attempting to do an unsupported operation. We can write unit tests with expected failures, which should provide a clear roadmap for things to fix upstream in sparse.

We could attempt to define a minimum required implementation, but in practice I suspect this will be hard to nail down definitively. The ultimate determinant of what works will be xarray's implementation.

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  467771005
Powered by Datasette · Queries took 237.91ms · About: xarray-datasette