issue_comments: 515845749

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3153#issuecomment-515845749 https://api.github.com/repos/pydata/xarray/issues/3153 515845749 MDEyOklzc3VlQ29tbWVudDUxNTg0NTc0OQ== 1217238 2019-07-29T05:04:24Z 2019-07-29T05:04:24Z MEMBER

@HasanAhmadQ7 thanks for looking into this!

I think this could be solved a little more cleanly at a lower level of xarray's indexing logic. In particular, all of our indexing calls go through convert_label_indexer, which in turn uses get_loc and get_indexer_nd helper functions to wrap the calls into pandas.Index methods: https://github.com/pydata/xarray/blob/1d7bcbdc75b6d556c04e2c7d7a042e4379e15303/xarray/core/indexing.py#L106-L118

These helper function would be a good place to implement this casting logic -- and you might even consider trying to fix it upstream in pandas as well.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   470712573