issue_comments: 512583158

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3117#issuecomment-512583158 https://api.github.com/repos/pydata/xarray/issues/3117 512583158 MDEyOklzc3VlQ29tbWVudDUxMjU4MzE1OA== 1217238 2019-07-17T21:53:50Z 2019-07-17T21:53:50Z MEMBER

Would it make sense to just assume that all non-DataArray NEP-18 compliant arrays do not contain an xarray-compliant coords attribute?

Yes, let's switch: coords = getattr(data, 'coords', None) to if isinstance(data, DataArray): coords = data.coords

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   467771005