home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 512582286

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3139#issuecomment-512582286 https://api.github.com/repos/pydata/xarray/issues/3139 512582286 MDEyOklzc3VlQ29tbWVudDUxMjU4MjI4Ng== 5635139 2019-07-17T21:50:29Z 2019-07-17T21:50:29Z MEMBER

I'm +1 on the relative dim / coord importance

But I also think this would be v disruptive, even with a deprecation period and some clever guessing. Maybe I'm being overly precious (we successfully changed the name of the library!); but I can imagine hundreds of warnings for people to swap argument order all over their code.

A couple of ideas if we did decide this: - Encourage people to pass dim and coords as keyword rather than positional args - Read them as *args prior to a ** separator and then warn if passed there - Then at least there's no ambiguity - An even later version could remove this restriction and reverse the order - Is there any from_foo constructors that would help here? I don't think so, but I've often found that resolves constructor discussions

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  469440752
Powered by Datasette · Queries took 0.792ms · About: xarray-datasette