issue_comments: 506840633

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3056#issuecomment-506840633 https://api.github.com/repos/pydata/xarray/issues/3056 506840633 MDEyOklzc3VlQ29tbWVudDUwNjg0MDYzMw== 23738400 2019-06-28T18:49:36Z 2019-06-28T18:49:36Z CONTRIBUTOR

It is an issue of incompatibilities with sphinx_rtd_theme and sphinx2, and I am not sure when will it be solved, I have looked a little into it but for now I don't know how. There is one small problem with xarray doc generation behaviour. In the doc/environment.yml the sphinx version is fixed to 1.8, however, in the rtd build, the doc/enviroment.yml is overridden and sphinx 2 is used. I generated the docs locally with the environment in doc/ (right) to compared with the online docs (left):

I have no clear preference between sphinx1 or sphinx2, but both online and local docs should be the same. If you prefer sphinx2, I have no problem modifying doc/environment.yml, otherwise, I don't think a pull request can solve it (the build script in in the rtd website does not look like the one on github).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   462122623