home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 505514716

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2616#issuecomment-505514716 https://api.github.com/repos/pydata/xarray/issues/2616 505514716 MDEyOklzc3VlQ29tbWVudDUwNTUxNDcxNg== 1217238 2019-06-25T16:12:03Z 2019-06-25T16:12:03Z MEMBER

I started thinking about names for these functions again....

I don't love the non-descriptive nature of combine_auto and combine_manual. All "auto" and "manual" tells me is that one is more automatic than the other, without saying how it's more automatic. This is probably even more confusing because we used "auto" previously to mean some hybrid behavior between what we now call "manual" and "auto".

What about calling these combine_by_coords and combine_nested instead? On open_mfdataset, these would be combine='by_coords' and combine='nested'.

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  391865060
Powered by Datasette · Queries took 0.917ms · About: xarray-datasette