issue_comments: 504276488

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2277#issuecomment-504276488 https://api.github.com/repos/pydata/xarray/issues/2277 504276488 MDEyOklzc3VlQ29tbWVudDUwNDI3NjQ4OA== 6164157 2019-06-21T03:35:49Z 2019-06-21T03:36:43Z CONTRIBUTOR

Hold the press! we can't merge. It seems like the new functionality messes up the faceted lineplots. If we define ds=xr.tutorial.scatter_example_dataset() then current behavior is :

ds.A.plot(col='x', row='w', hue='z'):

but with the pull request we screw up the legend

I need to look at this.

Also - kinda unsettling that this was not picked up by any unit test.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   340069538