issue_comments: 503502211
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/2706#issuecomment-503502211 | https://api.github.com/repos/pydata/xarray/issues/2706 | 503502211 | MDEyOklzc3VlQ29tbWVudDUwMzUwMjIxMQ== | 8643775 | 2019-06-19T10:24:47Z | 2019-06-19T10:24:47Z | NONE | Hi all, sorry for the delay. I was on break for 10 days. I have started working on it now and should be able to do this in a couple of days. A quick thing I noticed as I started working on this: currently the zarr.Array.append function(which handles the resize of the array) is being used to append to the array, and as of now, it's not being done asynchronously using a dask delayed object(as I pointed out in my earlier comment). So to do it asynchronously, my plan is to resize the target array, and then the delayed object would write to the appropriate region of the resized array(dask.array.store is currently being used for this). But if for whatever reason, the delayed object does not end up being called, we would end up with nonsense values in the resized portion of the array(or whatever is the fill value). For this reason I wonder if I should put the resize in the delayed object too. Thoughts? |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
402908148 |