home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 502699808

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2706#issuecomment-502699808 https://api.github.com/repos/pydata/xarray/issues/2706 502699808 MDEyOklzc3VlQ29tbWVudDUwMjY5OTgwOA== 1197350 2019-06-17T14:12:59Z 2019-06-17T14:12:59Z MEMBER

@jendrikjoe - thanks for digging in and finding this important issue!

This PR has been hanging around for a long time. (A lot of that is on me!) It would be good to get something merged soon. Here's what I propose. - Identify which datatypes can easily be appended now (e.g. floats, etc.) and which cannot (variable length strings) - Raise an error if append is called on the incompatible datatypes - Move forward with this PR, which is otherwise very nearly ready - Open a new issue to keep track of the outstanding incompatible types, which require upstream resolution in zarr

How does that sound to everyone?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  402908148
Powered by Datasette · Queries took 79.779ms · About: xarray-datasette