issue_comments: 496536455

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2616#issuecomment-496536455 https://api.github.com/repos/pydata/xarray/issues/2616 496536455 MDEyOklzc3VlQ29tbWVudDQ5NjUzNjQ1NQ== 35968931 2019-05-28T14:17:39Z 2019-05-28T14:17:39Z MEMBER

Thanks for the detailed review @shoyer !

I'm loving all the documentation and test coverage here (though I haven't read them all carefully yet!).

Great - the only test I think you should definitely look at is test_manual_concat_too_many_dims_at_once, and my diagnosis of the issue it exposes in #2975.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   391865060